Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding a sentence #194

Merged
merged 5 commits into from
May 21, 2024
Merged

feat: Adding a sentence #194

merged 5 commits into from
May 21, 2024

Conversation

NeilGeorge1
Copy link
Contributor

@NeilGeorge1 NeilGeorge1 commented May 15, 2024

Added the required sentence

Description

This PR adds the required sentence after the full stop at line 75 in the code.

Related Tickets & Documents

Closes #175

Mobile & Desktop Screenshots/Recordings

Screenshot 2024-05-17 210525

Steps to QA

  1. Open the file the-secret-sauce.md on GitHub.
  2. Navigate to line 75.
  3. Check if the required sentence has been added after the full stop at line 75.
  4. If there are any issues or changes required, please provide details in the comments section of the PR.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@NeilGeorge1 NeilGeorge1 requested a review from a team as a code owner May 15, 2024 16:18
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

netlify bot commented May 15, 2024

Deploy Preview for sauced-intro ready!

Name Link
🔨 Latest commit 47cc927
🔍 Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/664c50fb918b200008b859bc
😎 Deploy Preview https://deploy-preview-194--sauced-intro.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @NeilGeorge1! ✨

However, there are some checks that failed.
Please address each of them until all checks pass befire we can review your PR.

Let us know if you have questions or need help.

Thank you. 🙂

@NeilGeorge1
Copy link
Contributor Author

No problem! @adiati98
Sure i'll address them rightaway

@NeilGeorge1 NeilGeorge1 changed the title Adding a sentence Feat: Adding a sentence May 16, 2024
@NeilGeorge1 NeilGeorge1 changed the title Feat: Adding a sentence feat: Adding a sentence May 16, 2024
@adiati98
Copy link
Member

Hi @NeilGeorge1,

You still have one failed check here.
Please read the message carefully so you can resolve the bot. 🙂

Copy link
Member

@BekahHW BekahHW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit pick: on our docs to learn how to use OpenSauced to land a job in the tech industry.

Instead of "on our docs" let's use "in our docs"

@NeilGeorge1
Copy link
Contributor Author

Hello @adiati98
Sorry this was my first time I will try resolving this.
@BekahHW Sure will do the necessary changes

@adiati98 adiati98 merged commit a38065a into open-sauced:main May 21, 2024
7 checks passed
samucodesh added a commit to samucodesh/intro that referenced this pull request May 21, 2024
    [Related PR](open-sauced#194)

    This commit adds a link to the Job Seekers Guide within the 'La Salsa Secreta' file of the Spanish translation.

    This provides additional resources for individuals seeking employment opportunities in the tech industry.
@NeilGeorge1 NeilGeorge1 deleted the adding-a-sentence branch May 22, 2024 02:41
samucodesh added a commit to samucodesh/intro that referenced this pull request May 28, 2024
    [Related PR](open-sauced#194)

    This commit adds a link to the Job Seekers Guide within the 'La Salsa Secreta' file of the Spanish translation.

    This provides additional resources for individuals seeking employment opportunities in the tech industry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add a link to the "Job Seekers Guide"
3 participants